3.19.8-ckt11 -stable review patch.  If anyone has any objections, please let me 
know.

------------------

From: Sifan Naeem <[email protected]>

commit 5728d95f2458887ae3d95547c04352bba5080ad6 upstream.

Using % can be slow depending on the architecture.

Using DIV_ROUND_UP is nicer and more efficient way to do it.

Fixes: commit 27bce457d588 ("i2c: img-scb: Add Imagination Technologies I2C SCB 
driver")
Signed-off-by: Sifan Naeem <[email protected]>
Acked-by: James Hogan <[email protected]>
Reviewed-by: James Hartley <[email protected]>
Signed-off-by: Wolfram Sang <[email protected]>
Signed-off-by: Kamal Mostafa <[email protected]>
---
 drivers/i2c/busses/i2c-img-scb.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
index 3d8b842..ef8eee1 100644
--- a/drivers/i2c/busses/i2c-img-scb.c
+++ b/drivers/i2c/busses/i2c-img-scb.c
@@ -1177,9 +1177,7 @@ static int img_i2c_init(struct img_i2c *i2c)
                int_bitrate++;
 
        /* Setup TCKH value */
-       tckh = timing.tckh / clk_period;
-       if (timing.tckh % clk_period)
-               tckh++;
+       tckh = DIV_ROUND_UP(timing.tckh, clk_period);
 
        if (tckh > 0)
                data = tckh - 1;
@@ -1199,9 +1197,7 @@ static int img_i2c_init(struct img_i2c *i2c)
        img_i2c_writel(i2c, SCB_TIME_TCKL_REG, data);
 
        /* Setup TSDH value */
-       tsdh = timing.tsdh / clk_period;
-       if (timing.tsdh % clk_period)
-               tsdh++;
+       tsdh = DIV_ROUND_UP(timing.tsdh, clk_period);
 
        if (tsdh > 1)
                data = tsdh - 1;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to