* Steven Rostedt <[email protected]> wrote:
> On Fri, 04 Dec 2015 12:05:12 +1030
> Rusty Russell <[email protected]> wrote:
>
> > This is clever, but I would advise against such subtle code. We will never
> > be
> > able to remove this code once it is in.
> >
> > Would suggest making the non-CPUMASK_OFFSTACK stubs write garbage into the
> > cpumasks instead, iff !(flags & __GFP_ZERO).
>
> I actually thought of the same thing, but thought it was a bit harsh. If
> others
> think that's a better solution, then I'll submit a patch to do that.
That just makes things more fragile - 'garbage' will spread the breakage, and
if
the breakage is subtle, it will spread subtle breakage.
So why not use a kzmalloc_node() [equivalent] call instead of kmalloc_node(),
to
make sure it's all zeroed instead of uninitialized?
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
