* Linus Torvalds <torva...@linux-foundation.org> wrote:
> On Mon, Dec 7, 2015 at 12:49 AM, Ingo Molnar <mi...@kernel.org> wrote:
> > Xunlei Pang reported a scheduler bug in init_rootdomain(), which is
> > caused by improper use of alloc_cpumask_var(), which results in
> > uninitialized cpumasks being allocated.
> >
> > No-one noticed this scheduler bug for a long time, probably because
> > alloc_cpumask_var() does result in initialized cpumasks in the
> > !CPUMASK_OFFSTACK case - which is the vast majority of systems
> > out there.
> >
> > So migrate all alloc_cpumask_var() users over to zalloc_cpumask_var(), to
> > be
> > on the safe side.
>
> Ugh. I'd rather just see us say that "allocating a cpumask always returns a
> zeroed mask".
>
> There really is no reason to ever not zero it (they aren't _that_ big even on
> huge machines), so I'd rather just get rid of the "zalloc" version that is
> the
> less common one anyway.
Sure - that was my original suggestion, will reshape the series to do it like
that.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
