On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote:
> Trivial changes suggested by checkpatch.pl.
[]
> diff --git a/drivers/of/address.c b/drivers/of/address.c
[]
> @@ -23,7 +23,7 @@ static int __of_address_to_resource(struct device_node *dev,
> #ifdef DEBUG
> static void of_dump_addr(const char *s, const __be32 *addr, int na)
> {
> - printk(KERN_DEBUG "%s", s);
> + pr_debug("%s", s);
> while (na--)
> printk(" %08x", be32_to_cpu(*(addr++)));
> printk("\n");
mixing pr_debug and printk doesn't make much sense.
It might be nicer to use
static void of_dumpaddr(const char *s, const __be32 *addr, int na)
{
#ifdef DEBUG
...
#endif
}
to avoid the other static declaration
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
