On 12/09/2015 04:00 AM, xinhui wrote: > > If kmemdup fails, We need kfree *buff* first then return -ENOMEM. > Otherwise there is a memory leak. > > Signed-off-by: Pan Xinhui <xinhui....@linux.vnet.ibm.com>
Reviewed-by: Nathan Fontenot <nf...@linux.vnet.ibm.com> > --- > arch/powerpc/kernel/nvram_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c > index 32e2652..21a278b7 100644 > --- a/arch/powerpc/kernel/nvram_64.c > +++ b/arch/powerpc/kernel/nvram_64.c > @@ -542,9 +542,9 @@ static ssize_t nvram_pstore_read(u64 *id, enum > pstore_type_id *type, > time->tv_nsec = 0; > } > *buf = kmemdup(buff + hdr_size, length, GFP_KERNEL); > + kfree(buff); > if (*buf == NULL) > return -ENOMEM; > - kfree(buff); > > if (err_type == ERR_TYPE_KERNEL_PANIC_GZ) > *compressed = true; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
