On Fri, 2015-12-11 at 11:23 +0800, Herbert Xu wrote: > On Thu, Dec 10, 2015 at 08:39:45AM -0800, Tim Chen wrote: > > > > The inner cipher is called synchronously from the outer layer > > async cipher algorithm in cbc_mb_async_ablk_decrypt via > > > > err = crypto_blkcipher_crt(child_tfm)->decrypt( > > &rctx->desc, req->dst, req->src, req->nbytes); > > We should avoid bypassing the API and directly calling crypto > driver functions like this. > > What if you made it a proper ablkcipher and just called it through > the API? > > Thanks,
Direct call I assume have less overhead. Let me think about making the inner cipher ablkcipher. I may need to rewrite a lot of the glue layer :( Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
