On Thu, Dec 17, 2015 at 11:41:53AM +0000, Catalin Marinas wrote:
> On Wed, Dec 16, 2015 at 12:42:34AM +0300, Yury Norov wrote:
> > Reviewed-by: David Daney <dda...@caviumnetworks.com>
> > Signed-off-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com>
> > Signed-off-by: Christoph Muellner <christoph.muell...@theobroma-systems.com>
> > Signed-off-by: Yury Norov <yno...@caviumnetworks.com>
> > Signed-off-by: Andrew Pinski <andrew.pin...@caviumnetworks.com>
>
> Long description missing.
Hi, Catalin,
I think this patch (and patch #3 too) is trivial, and
explanation in patch name is clear enougth. So, I just do not
understand what else to explain here. Could you point me, and then I
will do it.
>
> > diff --git a/arch/arm64/include/asm/is_compat.h
> > b/arch/arm64/include/asm/is_compat.h
> > index 476db90..89b1f65 100644
> > --- a/arch/arm64/include/asm/is_compat.h
> > +++ b/arch/arm64/include/asm/is_compat.h
> > @@ -36,7 +36,6 @@ static inline int is_a32_compat_thread(struct thread_info
> > *thread)
> > #else
> >
> > static inline int is_a32_compat_task(void)
> > -
> > {
> > return 0;
> > }
>
> You should move this to the previous patch.
>
> > @@ -45,14 +44,39 @@ static inline int is_a32_compat_thread(struct
> > thread_info *thread)
> > {
> > return 0;
> > }
> > -
> > #endif /* CONFIG_AARCH32_EL0 */
>
> Maybe this one as well, though I like an empty line before the last
> #endif (i.e. drop this hunk).
It's just dirt, I'll clean it. Thank you.
Yury.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
