On Friday, December 18, 2015 06:39:34 AM Josh Poimboeuf wrote: > do_suspend_lowlevel() is a callable non-leaf function which doesn't > honor CONFIG_FRAME_POINTER, which can result in bad stack traces. > > Create a stack frame for it when CONFIG_FRAME_POINTER is enabled. > > Signed-off-by: Josh Poimboeuf <jpoim...@redhat.com> > Acked-by: Pavel Machek <pa...@ucw.cz> > Cc: Rafael J. Wysocki <r...@rjwysocki.net> > Cc: Len Brown <len.br...@intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > --- > arch/x86/kernel/acpi/wakeup_64.S | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kernel/acpi/wakeup_64.S > b/arch/x86/kernel/acpi/wakeup_64.S > index 8c35df4..169963f 100644 > --- a/arch/x86/kernel/acpi/wakeup_64.S > +++ b/arch/x86/kernel/acpi/wakeup_64.S > @@ -5,6 +5,7 @@ > #include <asm/page_types.h> > #include <asm/msr.h> > #include <asm/asm-offsets.h> > +#include <asm/frame.h> > > # Copyright 2003 Pavel Machek <pa...@suse.cz>, distribute under GPLv2 > > @@ -39,6 +40,7 @@ bogus_64_magic: > jmp bogus_64_magic > > ENTRY(do_suspend_lowlevel) > + FRAME_BEGIN > subq $8, %rsp > xorl %eax, %eax > call save_processor_state > @@ -109,6 +111,7 @@ ENTRY(do_suspend_lowlevel) > > xorl %eax, %eax > addq $8, %rsp > + FRAME_END > jmp restore_processor_state > ENDPROC(do_suspend_lowlevel) > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
