On Tuesday, December 22, 2015 04:03:07 AM Richard Guy Briggs wrote:
> Failed attempts to change the audit_pid configuration are not presently
> logged. One case is an attempt to starve an old auditd by starting up a
> new auditd when the old one is still alive and active. The other case
> is an attempt to orphan a new auditd when an old auditd shuts down.
>
> Log both as AUDIT_CONFIG_CHANGE messages with failure result.
>
> Signed-off-by: Richard Guy Briggs <r...@redhat.com>
> ---
> kernel/audit.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
Same as 1/2, applied to the audit next queue.
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 0368be2..9000c6f 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -882,11 +882,15 @@ static int audit_receive_msg(struct sk_buff *skb,
> struct nlmsghdr *nlh) int new_pid = s.pid;
> pid_t requesting_pid = task_tgid_vnr(current);
>
> - if ((!new_pid) && (requesting_pid != audit_pid))
> + if ((!new_pid) && (requesting_pid != audit_pid)) {
> + audit_log_config_change("audit_pid", new_pid,
> audit_pid, 0);
> return -EACCES;
> + }
> if (audit_pid && new_pid &&
> - audit_replace(requesting_pid) != -ECONNREFUSED)
> + audit_replace(requesting_pid) != -ECONNREFUSED) {
> + audit_log_config_change("audit_pid", new_pid,
> audit_pid, 0);
> return -EEXIST;
> + }
> if (audit_enabled != AUDIT_OFF)
> audit_log_config_change("audit_pid", new_pid,
> audit_pid, 1);
> audit_pid = new_pid;
--
paul moore
security @ redhat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
