On Mon, Jan 04, 2016 at 11:17:29AM -0600, Dinh Nguyen wrote: > We tried to jam the L2 and OCRAM EDAC functionality in the same > altr_edac.c file. It looks like it might be clean if we split out the L2 > and OCRAM functions into their appropriate files(altr_edac_l2.c and > altr_edac_ocram.c). Do you agree?
"Clean" in what sense? To me clean is when there's a single compilation unit altera_edac.c which contains all Altera-specific code. > These bindings were in a separate patch that you were not CC'd. I'll > keep you on the entire patch set in the future. Yes, I believe the devicetree definitions need to go hand-in-hand with its user(s). -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/