for_each_child_of_node performs an of_node_get on each iteration, so
to break out of the loop an of_node_put is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

 for_each_child_of_node(n, ...) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com>
---
 drivers/bus/arm-cci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 577cc4b..011b2f6 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1983,8 +1983,10 @@ static int cci_probe_ports(struct device_node *np)
 
                i = nb_ace + nb_ace_lite;
 
-               if (i >= nb_cci_ports)
+               if (i >= nb_cci_ports) {
+                       of_node_put(cp);
                        break;
+               }
 
                if (of_property_read_string(cp, "interface-type",
                                        &match_str)) {
-- 
1.9.1

Reply via email to