On Fri, Jan 29, 2016 at 02:26:54PM -0800, Jarkko Sakkinen wrote:
> On Fri, Jan 29, 2016 at 02:21:08PM -0800, Jarkko Sakkinen wrote:
> > On Fri, Jan 29, 2016 at 01:48:27PM -0700, Jason Gunthorpe wrote:
> > > On Thu, Jan 28, 2016 at 11:13:59PM -0800, Jarkko Sakkinen wrote:
> > > 
> > > > -       struct resource tmp = {};
> > > > -
> > > > -       tmp.start = start;
> > > > -       tmp.end = start + size - 1;
> > > > -       tmp.flags = IORESOURCE_MEM;
> > > > +       struct resource new_res = {
> > > > +               .start  = start,
> > > > +               .end    = size - 1,
> > > 
> > > That isn't right.
> > 
> > Whoops. Good catch, I'll update it before pull request. Thanks!
> 
> github.com/jsakkine/linux-tpmdd/commit/5012960093774c49d81c612eb32f92cfa1f619bc
> 
> struct resource new_res = {
>       .start  = start,
>       .end    = start + size - 1,
>       .flags  = IORESOURCE_MEM,
> };
> 
> Better?

Yes that looks ok

Jason

Reply via email to