On 03/02/16 00:36, Kenneth Westfield wrote:
On Mon, Feb 01, 2016 at 09:28:43AM -0800, Srinivas Kandagatla wrote:diff --git a/sound/soc/qcom/lpass-ipq806x.c b/sound/soc/qcom/lpass-ipq806x.c index 119048c..8bdcdcb 100644 --- a/sound/soc/qcom/lpass-ipq806x.c +++ b/sound/soc/qcom/lpass-ipq806x.c @@ -65,7 +65,10 @@ static struct snd_soc_dai_driver ipq806x_lpass_cpu_dai_driver = { static int ipq806x_lpass_alloc_dma_channel(struct lpass_data *drvdata, int dir) { - return IPQ806X_LPAIF_RDMA_CHAN_MI2S; + if (dir == SNDRV_PCM_STREAM_PLAYBACK) + return IPQ806X_LPAIF_RDMA_CHAN_MI2S; + else /* Capture not supported */ + return -EINVAL; }The comment could be read as "Capture not supported by hardware", which isn't true. Maybe "Capture currently not implemented"?
Agreed, I will change this in next version.
