On Wed, 3 Feb 2016 11:12:09 +0100 Ingo Molnar <[email protected]> wrote:
> * Peter Zijlstra <[email protected]> wrote: > > > On Mon, Feb 01, 2016 at 05:38:09PM -0500, Steven Rostedt wrote: > > > > > Regardless of this final patch, what do you think of the first three? I > > > can send them as a separate series, just to get more of the SCHED_DEBUG > > > code into debug.c. > > > > The first two looked ok, the third I had a vague niggle it might be part > > of something bigger and tearing it up like this might make it harder. Actually, I originally had plans to display the entire root domain here, but decided against that. > > Yeah, so the purpose of kernel/sched/debug.c is mostly meant as a filesystem > interface to display various internal scheduler details. It mostly deals with > /proc/sched_debug details: hence the name. > > Note that 'sched domain debugging' does not fit into that cleanly, because it > also > does sanity checking of the sched-domains data. So I'm not sure we want to do > patch #3 that moves sched-domain debugging to debug.c. > > So debug.c is named in a bit too generic fashion, attracting such patches. > It was actually more the #ifdef SCHED_DEBUG that attracted the patches. The debug.c file is compiled on SCHED_DEBUG, thus it appeared natural to have parts in core.c just moved into that file instead of having all the #ifdef SCHED_DEBUG in it. -- Steve
