On Wed, 3 Feb 2016, jiangyiwen wrote: > Date: Wed, 3 Feb 2016 17:54:36 +0800 > From: jiangyiwen <[email protected]> > To: [email protected], [email protected] > Cc: [email protected], [email protected], > Lukáš Czerner <[email protected]>, [email protected], > "Qijiang (Joseph, Euler)" <[email protected]> > Subject: [dm-devel] [PATCH] block: do not return -EOPNOTSUPP only when issue a > discard request > > commit 8af1954d172a("blkdev: Do not return -EOPNOTSUPP if discard > is supported") only solve the situation of discard, because When > applications issue a discard request to device, they can't expect > deterministic behaviour. However, WRITE SAME should not ignore error > with EOPNOTSUPP, because if applications issue WRITE SAME requests to > device, it should return deterministic results to applications > according to the T10 standard, or else it will cause an inconsistent > state between upper layer and bottom layer. > > So ignoring error with EOPNOTSUPP only in discard situation. > > Signed-off-by: Yiwen Jiang <[email protected]>
Looks good. Reviewed-by: Lukas Czerner <[email protected]> Thanks! -Lukas > --- > block/blk-lib.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/block/blk-lib.c b/block/blk-lib.c > index 9ebf653..e4f02f1 100644 > --- a/block/blk-lib.c > +++ b/block/blk-lib.c > @@ -19,7 +19,9 @@ static void bio_batch_end_io(struct bio *bio) > { > struct bio_batch *bb = bio->bi_private; > > - if (bio->bi_error && bio->bi_error != -EOPNOTSUPP) > + /* ignore -EOPNOTSUPP only when issue a discard request */ > + if (bio->bi_error && (!(bio->bi_rw & REQ_DISCARD) || > + (bio->bi_error != -EOPNOTSUPP))) > bb->error = bio->bi_error; > if (atomic_dec_and_test(&bb->done)) > complete(bb->wait); >
