On 08-02-16, 13:58, Rafael J. Wysocki wrote: > My most fundamental concern here is that attributes that don't apply > to a particular governor should not appear in sysfs at all when that > governor is in use (instead of appearing and always returning -EINVAL
s/is in use/is not in use/ ?? > which is sort of silly). But who said that I have made them available always ? Sorry, I didn't understood your input. I have just moved the show/store callbacks and the struct governor_attr definition to cpufreq_governor.c. And sysfs files are created only for the ones that are valid for a governor. > That doesn't mean the common code cannot access them, though. They > still can be present in the data structure, but it may be a good idea > to set them to special values clearly meaning "invalid" then. Or are you saying that we should move all the tunables to dbs_data ? -- viresh
