On Thu, Feb 11, 2016 at 6:52 AM, Tomeu Vizoso <[email protected]> wrote: > > On 02/05/2016 06:24 PM, Gwendal Grignou wrote: > > We should not used kmalloc when get events, these functions are called > > quite often. > > Gwendal. > > > > On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso <[email protected] > > <mailto:[email protected]>> wrote: > > > > +static int cros_ec_get_host_command_version_mask(struct > > cros_ec_device *ec_dev, > > + u16 cmd, u32 *mask) > > +{ > > + struct ec_params_get_cmd_versions *pver; > > + struct ec_response_get_cmd_versions *rver; > > + struct cros_ec_command *msg; > > + int ret; > > + > > + msg = kmalloc(sizeof(*msg) + max(sizeof(rver), sizeof(pver)), > > + GFP_KERNEL); > > + if (!msg) > > + return -ENOMEM; > > > > Victor's version in https://chromium-review.googlesource.com/272954 > > looks cleaner: no malloc, no need to cast rver. > > I agree that it looks cleaner, but how would you allocate the payload at > build time if it has to be max(sizeof(*pver), sizeof(*rver))? For this one, given cros_ec_get_host_command_version_mask() is called once, a kmalloc is fine.
Gwendal.
