On Tue, 2016-02-16 at 00:25 +0800, kbuild test robot wrote:
> drivers/bluetooth/hci_mrvl.c:411:9-10: WARNING: return of 0/1 in
> function 'mrvl_fw_loaded' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> CC: Ganapathi Bhat <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>
> ---
>
> hci_mrvl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/bluetooth/hci_mrvl.c
> +++ b/drivers/bluetooth/hci_mrvl.c
> @@ -408,9 +408,9 @@ static bool mrvl_fw_loaded(struct hci_ua
> struct fw_data *fw_data = mrvl->fwdata;
>
> if ((get_cts(hu->tty)) || (fw_data->fw_loaded))
> - return 1;
> + return true;
> else
> - return 0;
> + return false;
> }
Nicer might be
return get_cts(hu->tty) || fw_data->fw_loaded;
> /* Set the baud rate */
