On Wed, Feb 17, 2016 at 11:02:56PM +0100, Joachim Eastwood wrote:
> Hi Andrew,
>
> On 17 February 2016 at 21:07, Andrew Lunn <and...@lunn.ch> wrote:
> > Add a regmap for accessing the EEPROM, and then use that with the
> > NVMEM framework. Enable backward compatibility in the MVMEM config
>
> typo: MVMEM
Thanks
> > +/*
> > + * Provide a regmap interface, which is registered with the NVMEM
> > + * framework
> > +*/
> > +static int eeprom_93xx46_regmap_read(void *context, const void *reg,
> > + size_t reg_size, void *val,
> > + size_t val_size)
> > +{
> > + struct eeprom_93xx46_dev *eeprom_93xx46 = context;
> > + off_t offset = *(u32 *)reg;
> > + int err;
> > +
> > + err = eeprom_93xx46_read(eeprom_93xx46, val, offset, val_size);
> > + if (err)
> > + return err;
> > + return 0;
>
> Can be:
> return eeprom_93xx46_read(eeprom_93xx46, val, offset, val_size);
>
> Allows you to remove the 'err' variable also.
Nope. regmap wants a return value of 0 or error. eeprom_93xx46_read()
returns how many bytes where actually read. So we either need this
code here, or we change the return from eeprom_93xx46_read().
Andrew
