On Thu, 25 Feb 2016, Andy Gross wrote: > On Thu, Feb 25, 2016 at 08:17:37AM -0800, Bjorn Andersson wrote: > > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> > > --- > > drivers/soc/qcom/smp2p.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > > index f1eed7f9dd67..61df598444e6 100644 > > --- a/drivers/soc/qcom/smp2p.c > > +++ b/drivers/soc/qcom/smp2p.c > > @@ -379,7 +379,7 @@ static int qcom_smp2p_alloc_outbound_item(struct > > qcom_smp2p *smp2p) > > return PTR_ERR(out); > > } > > > > - memset(out, 0, sizeof(*out)); > > + memset_io(out, 0, sizeof(*out)); > > out->magic = SMP2P_MAGIC; > > out->local_pid = smp2p->local_pid; > > out->remote_pid = smp2p->remote_pid; > > Good catch. I'll add this fix for the pull.
Folks, is qmem_smem_get() intended to return pointers to device-mapped memory, as implied by this change? If so, shouldn't the return type of qmem_smem_get() et al. be void __iomem * rather than void *? - Paul
