> -----Original Message----- > From: Arnd Bergmann [mailto:[email protected]] > Sent: Wednesday, March 02, 2016 9:59 AM > To: Dmitry Torokhov <[email protected]> > Cc: [email protected]; Arnd Bergmann <[email protected]>; > Shawn Guo <[email protected]>; [email protected]; Javier > Martinez Canillas <[email protected]>; Frank Li > <[email protected]>; [email protected]; linux- > [email protected] > Subject: [PATCH 12/14] keyboard: snvs-pwrkey: use __maybe_unused to hide > pm functions > > The SNVS power key driver has suspend/resume functions that are accessed > using SIMPLE_DEV_PM_OPS, which hide the reference when > CONFIG_PM_SLEEP is not set, resulting in a warning about unused functions: > > drivers/input/keyboard/snvs_pwrkey.c:183:12: error: > 'imx_snvs_pwrkey_suspend' defined but not used [-Werror=unused-function] > drivers/input/keyboard/snvs_pwrkey.c:194:12: error: > 'imx_snvs_pwrkey_resume' defined but not used [-Werror=unused-function] > > This adds __maybe_unused annotations to let the compiler know it can > silently drop the function definition. > > Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: Frank Li <[email protected]> > --- > drivers/input/keyboard/snvs_pwrkey.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/snvs_pwrkey.c > b/drivers/input/keyboard/snvs_pwrkey.c > index 9adf13a5864a..b0ffadeb208c 100644 > --- a/drivers/input/keyboard/snvs_pwrkey.c > +++ b/drivers/input/keyboard/snvs_pwrkey.c > @@ -180,7 +180,7 @@ static int imx_snvs_pwrkey_probe(struct > platform_device *pdev) > return 0; > } > > -static int imx_snvs_pwrkey_suspend(struct device *dev) > +static int __maybe_unused imx_snvs_pwrkey_suspend(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct pwrkey_drv_data *pdata = platform_get_drvdata(pdev); @@ - > 191,7 +191,7 @@ static int imx_snvs_pwrkey_suspend(struct device *dev) > return 0; > } > > -static int imx_snvs_pwrkey_resume(struct device *dev) > +static int __maybe_unused imx_snvs_pwrkey_resume(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct pwrkey_drv_data *pdata = platform_get_drvdata(pdev); > -- > 2.7.0
