On Thu, Mar 3, 2016 at 11:32 AM, Joe Perches <[email protected]> wrote: > with your patch get_maintainer.pl and --git-blame gives: > > $ ./scripts/get_maintainer.pl ~/1.diff --git-blame > Thomas Gleixner <[email protected]> > (commit_signer:20/19=100%,authored:7/19=37%,added_lines:73/248=29%,removed_lines:38/119=32%) > Peter Zijlstra <[email protected]> > (commit_signer:3/19=16%,authored:1/19=5%) > Andrew Morton <[email protected]> (commit_signer:3/19=16%,modified > commits:2/3=67%) > Davidlohr Bueso <[email protected]> > (commit_signer:3/19=16%,authored:3/19=16%,added_lines:113/248=46%,removed_lines:20/119=17%) > Ingo Molnar <[email protected]> (commit_signer:2/19=11%,modified > commits:2/3=67%) > Dominik Dingel <[email protected]> (authored:1/19=5%) > Jann Horn <[email protected]> (authored:1/19=5%) > Sebastian Andrzej Siewior <[email protected]> (added_lines:29/248=12%) > "Kirill A. Shutemov" <[email protected]> > (added_lines:14/248=6%,removed_lines:49/119=41%) > Darren Hart <[email protected]> (modified commits:1/3=33%) > Stephen Hemminger <[email protected]> (modified commits:1/3=33%) > Christian Borntraeger <[email protected]> (modified commits:1/3=33%) > [email protected] (open list) > > vs > > $ ./scripts/get_maintainer.pl ~/1.diff > Thomas Gleixner <[email protected]> > (commit_signer:20/19=100%,authored:7/19=37%,added_lines:73/248=29%,removed_lines:38/119=32%) > Davidlohr Bueso <[email protected]> > (commit_signer:3/19=16%,authored:3/19=16%,added_lines:113/248=46%,removed_lines:20/119=17%) > Peter Zijlstra <[email protected]> (commit_signer:3/19=16%) > Andrew Morton <[email protected]> (commit_signer:3/19=16%) > Ingo Molnar <[email protected]> (commit_signer:2/19=11%) > Rasmus Villemoes <[email protected]> (authored:1/19=5%) > Darren Hart <[email protected]> (authored:1/19=5%) > kbuild test robot <[email protected]> (authored:1/19=5%) > Sebastian Andrzej Siewior <[email protected]> (added_lines:29/248=12%) > "Kirill A. Shutemov" <[email protected]> > (added_lines:14/248=6%,removed_lines:49/119=41%)
So original author's email would be spit out only if given --git-blame, instead of by default, which really surprises people. Since most time we will cc original author, we have to use --git-blame explicitly, thus pay the running time cost. So the runtime argument don't stands, why not just enable it by default? Regards, Jianyu Zhan
