On Fri, Mar 11, 2016 at 11:38:19PM +0800, Minfei Huang wrote: > I think we can modify the logic a bit to make code simple. Thus gcc will > not complain about any more, and the logic is earier.
This is a Smatch warning, not a GCC warning. If you think the new code is clearer, that's fine but don't just silence the warning to please Smatch. I'm pretty sure I can silence this warning in Smatch. regards, dan carpenter