On Wed, Mar 23, 2016 at 10:45:42AM -0600, Jason Gunthorpe wrote: > On Wed, Mar 23, 2016 at 08:16:09AM +0200, Jarkko Sakkinen wrote: > > Dropped the field 'base' from struct tpm_vendor_specific and migrated > > it to the private structures of tpm_atmel and tpm_nsc. > > > > Signed-off-by: Jarkko Sakkinen <[email protected]> > > > +#define atmel_get_priv(chip) ((struct tpm_atmel_priv *) chip->vendor.priv) > > This should be a static inline function not a define > > > +#define tpm_nsc_get_priv(chip) ((struct tpm_nsc_priv *) chip->vendor.priv) > > Ditto > > Otherwise looks ok > > Reviewed-by: Jason Gunthorpe <[email protected]>
Thank you. In my the commit now in my master branch they are now changed as static inline functions. > Jason /Jarkko

