Em Tue, Apr 05, 2016 at 02:24:19PM +0900, Taeung Song escreveu: > On 04/05/2016 07:07 AM, Vinson Lee wrote: > > if (!strcmp(var, "buildid.dir")) { > >- const char *dirname = perf_config_dirname(var, value); > >+ const char *v = perf_config_dirname(var, value); > > Why you use 'v' variable name ? > > 'v' variable name was used in set_buildid_dir(), too. > But I send a patch renaming 'v' to 'home' because 'home' is more readable. > 37194f4 ("perf config: Rename 'v' to 'home' in set_buildid_dir()") > https://lkml.org/lkml/2016/3/27/98 > > IMHO, I like using 'dir' instead of 'v'.
Whatever, I'm switching this to 'dir', but don't pay _that_ much attention to variables that have such a narrow scope... - Arnaldo