Hi Rob, On 4/7/2016 6:57 PM, Rob Herring wrote: > On Mon, Apr 04, 2016 at 11:48:23AM +0100, Joao Pinto wrote: >> >> Hi Rob, >> >> On 4/4/2016 6:15 AM, Rob Herring wrote: >>> On Thu, Mar 31, 2016 at 07:57:21PM +0100, Joao Pinto wrote: >>>> This patch adds a glue platform driver for the Synopsys G210 Test Chip. >>>> >>>> Signed-off-by: Joao Pinto <jpi...@synopsys.com> >>>> --- >> >> [snip] >> >>>> + >>>> +Required properties: >>>> +- compatible : compatible list must contain the PHY type & version: >>>> + "snps, g210-tc-6.00-20bit" >>>> + "snps, g210-tc-6.00-40bit" >>> Remove the space ^ >>> >>>> + complemented with the Controller IP version: >>>> + "snps, dwc-ufshcd-1.40a" >>> >>> ditto >> >> Ok, will do that! >> >>> >>> Combining the phy and controller compatible strings is a bit strange. >>> Generally, they would be separate nodes using the common phy binding. >>> >> >> Correct, but in this case is just the compatibility string is just to tell >> the >> dw ufs host that it has a 40-bit or a 20-bit test chip connected. The Test >> chip >> is initialized by a unipro command sequence and there is no more ops related >> to it. > > Okay. In that case, I think it should be a separate property unless the > controller h/w is synthesized for one or the other.
Yes, the hardware must be synthesized for a certain PHY type, 20 or 40-bit. > > Rob > Joao
