On Tue, 16 Jan 2007 15:13:32 -0500 Neil Horman <[EMAIL PROTECTED]> wrote:
> As it is currently written, sys_select checks its return code to convert > ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, and > so if select is called from userspace with a NULL timeval, then it is possible > for the ERESTARTNOHAND errno to leak into userspace, which is incorrect. This > patch moves that check outside of the conditional, and prevents the errno > leak. the ERESTARTNOHAND thing is handled in arch specific signal code, syscalls can return -ERESTARTNOHAND as much as they want (and your change breaks the current behaviour of select()). For example: arch/x86_64/kernel/signal.c /* Are we from a system call? */ if ((long)regs->orig_rax >= 0) { /* If so, check system call restarting.. */ switch (regs->rax) { case -ERESTART_RESTARTBLOCK: case -ERESTARTNOHAND: regs->rax = -EINTR; break; -- Paolo Ornati Linux 2.6.20-rc5 on x86_64 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/