On Fri, 29 Apr 2016 11:54:54 -0300 Arnaldo Carvalho de Melo <a...@kernel.org> wrote:
> Em Fri, Apr 29, 2016 at 11:46:32PM +0900, Masami Hiramatsu escreveu: > > Hi Arnaldo, > > > > This patch series does refactoring strbuf and xrealloc related code > > to remove xrealloc since it can call die() to exit immediately when > > it hits any error. Instead of that, it should return error code to > > the caller so that the caller can handle its error. > > > > Thus, at first, this changes the strbuf APIs to return error code > > instead of die() immediately. And then changing API callers according > > to the following rules. > > - Check the return value of strbuf APIs and handle errors and, > > - If the caller returns an error code (errno), it returns > > the return value of strbuf APIs. > > - If the caller just return -1 or NULl in error case, it also > > returns -1 or NULL in case of strbuf error. > > - If the caller can call die() directly, it also call die() > > in case of strbuf error. > > - Error checking patches are splitted for each subcommand, since > > it will help review. > > > > This also removes xrealloc and ALLOC_GROW from libperf, so that no > > one use it anymore. > > > > This series actually depends on the series of SDT support patches > > which I've sent an hour ago. It is also able to change this not to > > depend on it easily. Please ask me if you'd like so. > > Please do so, as this one looks easier to review, so can go in faster. OK, I sent it as v2 in order to avoid confusion. Thank you! -- Masami Hiramatsu <mhira...@kernel.org>
