2016-05-04 3:46 GMT+08:00 Matt Fleming <m...@codeblueprint.co.uk>: > If we're accessing rq_clock() (e.g. in sched_avg_update()) we should > update the rq clock before calling cpu_load_update(), otherwise any > time calculations will be stale. > > All other paths currently call update_rq_clock(). > > Cc: Peter Zijlstra <pet...@infradead.org> > Cc: Ingo Molnar <mi...@kernel.org> > Cc: Mike Galbraith <umgwanakikb...@gmail.com> > Cc: Mel Gorman <mgor...@techsingularity.net> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Frederic Weisbecker <fweis...@gmail.com> > Cc: Rik van Riel <r...@redhat.com> > Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk>
Reviewed-by: Wanpeng Li <wanpeng...@hotmail.com> > --- > kernel/sched/fair.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index b8a33abce650..aa9ba82f0d7c 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4723,6 +4723,7 @@ void cpu_load_update_nohz_stop(void) > > load = weighted_cpuload(cpu_of(this_rq)); > raw_spin_lock(&this_rq->lock); > + update_rq_clock(this_rq); > cpu_load_update_nohz(this_rq, curr_jiffies, load); > raw_spin_unlock(&this_rq->lock); > } > -- > 2.7.3 > -- Regards, Wanpeng Li
