On 2016-05-04 05:12, buzdelab...@gmail.com wrote: > From: Dom Cote <buzdelabuz2+...@gmail.com> > > Replace the addition (+) of 2 python 'memoryview' objects > with the addition of 2 'bytes' objects, convert the result > back to memoryview. > > Tested with python 3.4 and 2.7 > Tested with gdb 7.7
A word here on what setup was found broken would have been good. If you have a sentence at hand, we can fold it in during merge. > > Signed-off-by: Dom Cote <buzdelabuz2+...@gmail.com> > --- > scripts/gdb/linux/dmesg.py | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/scripts/gdb/linux/dmesg.py b/scripts/gdb/linux/dmesg.py > index 927d0d2a3145..04d6719067f2 100644 > --- a/scripts/gdb/linux/dmesg.py > +++ b/scripts/gdb/linux/dmesg.py > @@ -33,11 +33,12 @@ class LxDmesg(gdb.Command): > if log_first_idx < log_next_idx: > log_buf_2nd_half = -1 > length = log_next_idx - log_first_idx > - log_buf = inf.read_memory(start, length) > + log_buf = utils.read_memoryview(inf, start, length).tobytes() > else: > log_buf_2nd_half = log_buf_len - log_first_idx > - log_buf = inf.read_memory(start, log_buf_2nd_half) + \ > - inf.read_memory(log_buf_addr, log_next_idx) > + a = utils.read_memoryview(inf, start, log_buf_2nd_half) > + b = utils.read_memoryview(inf, log_buf_addr, log_next_idx) > + log_buf = a.tobytes() + b.tobytes() > > pos = 0 > while pos < log_buf.__len__(): > Patches look good to me on first glance. Need to try out as well. Kieran? Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
