On Fri, 6 May 2016, hchrzani wrote:
> CHA events in Knights Landing platform require programming filter registers
> properly.
> Before change, code lacked mandatory bitset operations for reserved bits.
> As a result some events were not counted.
>
> Fixes: 77af003 ('perf/x86/intel/uncore: Add Knights Landing uncore PMU
> support')
> Signed-off-by: Hubert Chrzaniuk <[email protected]>
> Signed-off-by: Lawrence F Meadows <[email protected]>
> ---
> arch/x86/events/intel/uncore_snbep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/events/intel/uncore_snbep.c
> b/arch/x86/events/intel/uncore_snbep.c
> index ab2bcaa..47d7216 100644
> --- a/arch/x86/events/intel/uncore_snbep.c
> +++ b/arch/x86/events/intel/uncore_snbep.c
> @@ -1902,6 +1902,7 @@ static int knl_cha_hw_config(struct intel_uncore_box
> *box,
> reg1->reg = HSWEP_C0_MSR_PMON_BOX_FILTER0 +
> KNL_CHA_MSR_OFFSET * box->pmu->pmu_idx;
> reg1->config = event->attr.config1 & knl_cha_filter_mask(idx);
> + reg1->config |= 0x23ull << 32;
Please use proper defines and not some magic hex constants.
Thanks,
tglx
