Commit-ID:  36a39ac967a548154a0fe44d71cb0063fa05010f
Gitweb:     http://git.kernel.org/tip/36a39ac967a548154a0fe44d71cb0063fa05010f
Author:     Borislav Petkov <b...@suse.de>
AuthorDate: Sat, 7 May 2016 11:59:40 +0200
Committer:  Ingo Molnar <mi...@kernel.org>
CommitDate: Tue, 10 May 2016 10:12:02 +0200

x86/boot: Comment what finalize_identity_maps() does

So it is not really obvious that finalize_identity_maps() doesn't do any
finalization but it *actually* writes CR3 with the ident PGD. Comment
that at the call site.

Signed-off-by: Borislav Petkov <b...@suse.de>
Cc: Andy Lutomirski <l...@amacapital.net>
Cc: Borislav Petkov <b...@alien8.de>
Cc: Brian Gerst <brge...@gmail.com>
Cc: Denys Vlasenko <dvlas...@redhat.com>
Cc: H. Peter Anvin <h...@zytor.com>
Cc: Kees Cook <keesc...@chromium.org>
Cc: Linus Torvalds <torva...@linux-foundation.org>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: a...@linux-foundation.org
Cc: b...@redhat.com
Cc: dyo...@redhat.com
Cc: jkos...@suse.cz
Cc: linux-tip-comm...@vger.kernel.org
Cc: l...@kernel.org
Cc: vgo...@redhat.com
Cc: ying...@kernel.org
Link: http://lkml.kernel.org/r/20160507100541.ga24...@pd.tnic
Signed-off-by: Ingo Molnar <mi...@kernel.org>
---
 arch/x86/boot/compressed/kaslr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index f82975b..f5a138c 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -437,6 +437,8 @@ unsigned char *choose_random_location(unsigned long input,
        choice = random_addr;
 
        add_identity_map(choice, output_size);
+
+       /* This actually loads the identity pagetable on x86_64. */
        finalize_identity_maps();
 out:
        return (unsigned char *)choice;

Reply via email to