Hi Lee, 2016-05-10 20:26 GMT+09:00 Lee Jones <lee.jo...@linaro.org>: >> +}; >> +MODULE_DEVICE_TABLE(of, uniphier_mfd_match); > > NACK. Please do not mix MFD and DT registration.
OK, thanks for review. My basic thought was: - Add an MFD node to my DTS only once. If I need to expand it in the future, I will just need to modify drivers/mtd/uniphier-mfd.c. It is just kernel-internal modification, so it does not bother DT binding at all. - Simplify the node topology of DTS. -- Best Regards Masahiro Yamada