On Fri, May 13, 2016 at 02:42:06PM -0700, Doug Anderson wrote: > On Thu, May 12, 2016 at 3:35 PM, Brian Norris <[email protected]> > wrote: > > + emmc_phy: phy@f780 { > > + compatible = "rockchip,rk3399-emmc-phy"; > > + reg = <0xf780 0x20>; > > This is slightly wrong. It should be: > > reg = <0xf780 0x24>; > > The status register is at an offset of 0x20 and is 4 bytes big, so we > need room for it.
Fixed. > After that is fixed, feel free to add my Reviewed-by tag. Done. Thanks for the review. Brian
