On Fri, Jun 03, 2016 at 05:58:40PM -0500, Josh Poimboeuf wrote:
> Commit cb2517653fcc ("sched/debug: Make schedstats a runtime tunable
> that is disabled by default") introduced a bug when CONFIG_SCHEDSTATS is
> enabled and the runtime tunable is disabled (which is the default). The
> wait-time, sum-exec, and sum-sleep fields are missing from the
> /proc/sched_debug file in the runnable_tasks section.
>
I take it that this breaks userspace parsing?
> Fix it with a new schedstat_val() macro which returns the field value
> when schedstats is enabled and zero otherwise. The macro works with
> both SCHEDSTATS and !SCHEDSTATS. I put the macro in stats.h since it
> might end up being useful in other places.
>
> Fixes: cb2517653fcc ("sched/debug: Make schedstats a runtime tunable that is
> disabled by default")
> Cc: [email protected]
> Signed-off-by: Josh Poimboeuf <[email protected]>
Acked-by: Mel Gorman <[email protected]>
--
Mel Gorman
SUSE Labs
