On Wed, Jun 8, 2016 at 12:05 PM, Jason Gunthorpe <jguntho...@obsidianresearch.com> wrote: > On Tue, Jun 07, 2016 at 05:45:39PM -0700, Ed Swierk wrote: >> + case 0x32041114: /* Atmel 3204 */ >> + chip->vendor.timeout_a = TIS_SHORT_TIMEOUT * HZ / 1000; >> + chip->vendor.timeout_b = TIS_LONG_TIMEOUT * HZ / 1000; >> + chip->vendor.timeout_c = TIS_SHORT_TIMEOUT * HZ / 1000; >> + chip->vendor.timeout_d = TIS_SHORT_TIMEOUT * HZ / 1000; > > Shouldn't these use msec_to_jiffies?
Indeed * HZ / 1000 can be one jiffy less than msec_to_jiffies(), depending on HZ. I'll change it. --Ed
