On Thu, Jun 09, 2016 at 09:43:28AM +0200, Lothar Wa??mann wrote: > Hi, > > On Wed, 8 Jun 2016 22:33:34 +0800 Dong Aisheng wrote: > > There's a powerdown bit already, so let's change the name of > > powerup_set bit to power_invert to reflects the power polarity > > to make it less confusing. > > > > Signed-off-by: Dong Aisheng <aisheng.d...@nxp.com> > > --- > > drivers/clk/imx/clk-pllv3.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > > index eea2b1b3791e..3fdfb6d2cc71 100644 > > --- a/drivers/clk/imx/clk-pllv3.c > > +++ b/drivers/clk/imx/clk-pllv3.c > > @@ -29,8 +29,8 @@ > > * struct clk_pllv3 - IMX PLL clock version 3 > > * @clk_hw: clock source > > * @base: base address of PLL registers > > - * @powerup_set: set POWER bit to power up the PLL > > - * @powerdown: pll powerdown offset bit > > + * @powerdown: pll powerdown bit offset > > + * @power_invert: set powerdown bit to power up the PLL > s/set/clear/ ? >
It is set. By default set the powerdown bit will powerdown the PLL according to spec. However, for IMX_PLLV3_USB, it's actually power up the PLL, so the power_invert reflect such using. Regards Dong Aisheng > > > Lothar Wa??mann > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
