On Tue, Jun 14, 2016 at 01:09:31PM +0300, Mika Westerberg wrote:
> On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote:
> > +static const struct platform_device_id pmic_gpio_id_table[] = {
> > + { "bxt_wcove_gpio", },
> > +};
>
> Do you really need this?
>
> > +
> > +static struct platform_driver wcove_gpio_driver = {
> > + .probe = wcove_gpio_probe,
> > + .remove = wcove_gpio_remove,
> > + .driver = {
> > + .name = "wcove_gpio",
> > + },
> > + .id_table = pmic_gpio_id_table,
>
> and this?
>
> > +};
> > +
> > +module_platform_driver(wcove_gpio_driver);
> > +
> > +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanic...@intel.com>");
> > +MODULE_DESCRIPTION("Intel Whiskey Cove GPIO Driver");
> > +MODULE_LICENSE("GPL v2");
>
> You can add
>
> MODULE_ALIAS("platform:wcove_gpio");
>
> to get the module loaded automatically.
Mika,
Thanks for your review. I'll address these in patch v2.
-Bin
