>
> Looks good. I have couple of minor comments, see below.
Thanks for review again.
>
> > + * Copyright (C) 2015 Intel Corporation. All rights reserved.
>
> It is 2016 now isn't it? :-)
Will fix this in v3.
> > +#define DRV_NAME "bxt_wcove_gpio"
>
> Drop this.
We have _TWO_ places using DRV_NAME(near the end of the file):
static struct platform_driver wcove_gpio_driver = {
.driver = {
.name = DRV_NAME,
},
and
MODULE_ALIAS("platform:" DRV_NAME);
You are suggesting to replace DRV_NAME with bxt_wcove_gpio(but why?)
or something else?
> > + * struct wcove_gpio - Whiskey Cove GPIO controller
> > + * @buslock: for bus lock/sync and unlock.
> > + * @chip: the abstract gpio_chip structure.
> > + * @regmap: the regmap from the parent device.
>
> Missing kernel-doc for regmap_irq_chip.
Will fix this in v3.
> > +static void wcove_update_irq_mask(struct wcove_gpio *wg,
> > + int gpio)
>
> Does this with into 80 chars?
Yes, it fits into 80 chars. Will fix in v3.
