Commit-ID: 5356c32742bd51c8c57065d2389a2c4bc036adcd Gitweb: http://git.kernel.org/tip/5356c32742bd51c8c57065d2389a2c4bc036adcd Author: Compostella, Jeremy <jeremy.composte...@intel.com> AuthorDate: Sat, 25 Jun 2016 08:20:24 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Mon, 27 Jun 2016 13:06:54 +0200
efibc: Report more information in the error messages Report the name of the EFI variable if the value size is too large, or if efibc_set_variable() fails to allocate the 'struct efivar_entry' object. If efibc_set_variable() fails because the 'size' value is too large, it also reports this value in the error message. Reported-by: Robert Elliott <elli...@hpe.com> Signed-off-by: Jeremy Compostella <jeremy.composte...@intel.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Arnd Bergmann <a...@arndb.de> Cc: Linus Torvalds <torva...@linux-foundation.org> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: linux-...@vger.kernel.org Link: http://lkml.kernel.org/r/1466839230-12781-2-git-send-email-m...@codeblueprint.co.uk [ Minor readability edits. ] Signed-off-by: Ingo Molnar <mi...@kernel.org> --- drivers/firmware/efi/efibc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/efibc.c b/drivers/firmware/efi/efibc.c index 8dd0c70..503bbe2 100644 --- a/drivers/firmware/efi/efibc.c +++ b/drivers/firmware/efi/efibc.c @@ -37,13 +37,13 @@ static int efibc_set_variable(const char *name, const char *value) size_t size = (strlen(value) + 1) * sizeof(efi_char16_t); if (size > sizeof(entry->var.Data)) { - pr_err("value is too large"); + pr_err("value is too large (%zu bytes) for '%s' EFI variable\n", size, name); return -EINVAL; } entry = kmalloc(sizeof(*entry), GFP_KERNEL); if (!entry) { - pr_err("failed to allocate efivar entry"); + pr_err("failed to allocate efivar entry for '%s' EFI variable\n", name); return -ENOMEM; }
