Hi, On Tuesday, June 28, 2016 01:25:04 PM Krzysztof Kozlowski wrote: > The clk notifier symbols are hidden by COMMON_CLK. However on some > platforms HAVE_CLK might be set while COMMON_CLK not which leads to > compile test build errors like: > > $ make.cross ARCH=sh > drivers/devfreq/tegra-devfreq.c: In function 'tegra_actmon_rate_notify_cb': > >> drivers/devfreq/tegra-devfreq.c:391:16: error: 'POST_RATE_CHANGE' > >> undeclared (first use in this function) > if (action != POST_RATE_CHANGE) > ^ > drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_probe': > >> drivers/devfreq/tegra-devfreq.c:654:8: error: implicit declaration of > >> function 'clk_notifier_register' [-Werror=implicit-function-declaration] > err = clk_notifier_register(tegra->emc_clock, &tegra->rate_change_nb); > ^ > > Export the macros and data type declarations outside of COMMON_CLK ifdef > and provide stubs to fix the compile testing. > > Reported-by: kbuild test robot <[email protected]> > Signed-off-by: Krzysztof Kozlowski <[email protected]> > > --- > > Reported when testing patch [1] on ARCH=sh. I don't have the sh cross > compile toolchain so I cannot verify whether this fixes reported issue.
FWIW I've verified with sh cross-compiler. Tested-by: Bartlomiej Zolnierkiewicz <[email protected]> > Tested on similar configuration on MIPS (HAVE_CLK && !COMMON_CLK) > > [1] http://www.gossamer-threads.com/lists/linux/kernel/2471798 Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
