Em Fri, Jul 01, 2016 at 10:27:35PM +0800, pi3orama escreveu: > > 在 2016年7月1日，下午9:40，Arnaldo Carvalho de Melo <a...@kernel.org> 写道： > > I.e. perhaps evsel->overwrite is completely unnecessary and places > > checking for it should instead check for evsel->attr.backward, no? > If we remove evsel->overwrite, what should we set in parser? Make it > directly setting attr?
yeah, is that possible? Trying... And then overwrite is how we chose to expose this to the user, in the event syntax, but internally that means using the backwards_ring buffer, right? So this simplifies the code, removing information that was being duplicated in evsel->overwrite and evsel->attr.write_backward. - Arnaldo
