On 04/07/16 11:03, Luca Abeni wrote: > Hi Juri, > > On Wed, 29 Jun 2016 20:07:43 +0100 > Juri Lelli <juri.le...@arm.com> wrote: > > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them, under a different name, to setup a new dl_entity, after: > > > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct > > sched_dl_entity" > > > > as we currently do > > > > setup_new_dl_entity(&p->dl, &p->dl) > > > > However, before Luca's change we were doing > > > > setup_new_dl_entity(dl_se, pi_se) > > > > in update_dl_entity() for a dl_se->new entity: we were using pi_se's > > parameters (the potential PI donor) for setting up a new entity. > > > > Restore this behaviour (as we want to correctly initialize parameters > > of a boosted task that enters DEADLINE) by removing the useless second > > parameter of setup_new_dl_entity() and retrieving the top waiter > > directly from inside that function. > I did not have time to test this patch yet, but it still looks good to > me. >
Thanks for reviewing it. Best, - Juri
