On 04/07/16 10:38, Peng Fan wrote:
> Use devm_request_irq to simplify error handling path,
> when probe smmu device.
>
> Also devm_{request|free}_irq when init or destroy domain context.
>
> Signed-off-by: Peng Fan <van.free...@gmail.com>
> Cc: Will Deacon <will.dea...@arm.com>
> Cc: Robin Murphy <robin.mur...@arm.com>
> ---
[...]
> @@ -2050,7 +2046,7 @@ static int arm_smmu_device_remove(struct
> platform_device *pdev)
> dev_err(dev, "removing device with active domains!\n");
>
> for (i = 0; i < smmu->num_global_irqs; ++i)
> - free_irq(smmu->irqs[i], smmu);
> + devm_free_irq(smmu->dev, smmu->irqs[i], smmu);
There shouldn't be any need for this at all, since the very next thing
called after drv->remove() is devres_release_all().
Robin.
>
> /* Turn the thing off */
> writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0);
>
