Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

[J Freyensee]

On Tue, 2016-07-12 at 11:06 +0000, weiyj...@163.com wrote:
> From: Wei Yongjun <yongjun_...@trendmicro.com.cn>
> 
> PTR_ERR should be applied before its argument is reassigned,
> otherwise the
> return value will be set to 0, not error code.

Another good catch.

Reviewed-by: Jay Freyensee <james_p_freyen...@linux.intel.com>

> 
> Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>

>       if (IS_ERR(req->mr)) {
> -             req->mr = NULL;
>               ret = PTR_ERR(req->mr);
> +             req->mr = NULL;
>       }