On Tue, 2016-07-12 at 15:26 -0700, Dan Williams wrote: > Given that nvdimm_flush() has higher overhead than wmb_pmem() (pointer > chasing through nd_region), and that we otherwise assume a platform has > ADR capability when flush hints are not present, move nvdimm_flush() to > REQ_FLUSH context. > > Note that we still arrange for nvdimm_flush() to be called even in the > ADR case. We need at least once wmb() fence to push buffered writes in > the cpu out to the ADR protected domain. > > Cc: Toshi Kani <[email protected]> > Cc: Ross Zwisler <[email protected]> > Signed-off-by: Dan Williams <[email protected]>
This looks good to me. Reviewed-by: Toshi Kani <[email protected]> Thanks, -Toshi

