> >> Paolo, would you prefer this, or the other approach you already ack'd ? > > > > I think I prefer the other, because vcpu_debug is not ratelimited. > > If the guest can trigger a printk it should always be ratelimited. > > Agree with rate limiting, but making this the default for everything doesn't > sound right IMO, especially for ignore_msrs=1. vcpu_unimpl is already rate > limited.
The problem is that your patch removes rate limiting whenever it now uses vcpu_debug. Paolo
