Signed-off-by: Dave Hansen <[EMAIL PROTECTED]>
---
lxc-dave/fs/utimes.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff -puN fs/utimes.c~16-24-elevate-write-count-for-do-utimes fs/utimes.c
--- lxc/fs/utimes.c~16-24-elevate-write-count-for-do-utimes 2007-02-09
14:26:55.000000000 -0800
+++ lxc-dave/fs/utimes.c 2007-02-09 14:26:55.000000000 -0800
@@ -58,16 +58,19 @@ static long do_utimes_nsec(int dfd, char
goto out;
inode = nd.dentry->d_inode;
+ error = mnt_want_write(nd.mnt);
+ if (error)
+ goto dput_and_out;
error = -EROFS;
if (IS_RDONLY(inode))
- goto dput_and_out;
+ goto mnt_drop_write_and_out;
/* Don't worry, the checks are done in inode_change_ok() */
newattrs.ia_valid = ATTR_CTIME | ATTR_MTIME | ATTR_ATIME;
if (times) {
error = -EPERM;
if (IS_APPEND(inode) || IS_IMMUTABLE(inode))
- goto dput_and_out;
+ goto mnt_drop_write_and_out;
newattrs.ia_atime = times[0];
newattrs.ia_mtime = times[1];
@@ -75,15 +78,17 @@ static long do_utimes_nsec(int dfd, char
} else {
error = -EACCES;
if (IS_IMMUTABLE(inode))
- goto dput_and_out;
+ goto mnt_drop_write_and_out;
if (current->fsuid != inode->i_uid &&
(error = vfs_permission(&nd, MAY_WRITE)) != 0)
- goto dput_and_out;
+ goto mnt_drop_write_and_out;
}
mutex_lock(&inode->i_mutex);
error = notify_change(nd.dentry, &newattrs);
mutex_unlock(&inode->i_mutex);
+mnt_drop_write_and_out:
+ mnt_drop_write(nd.mnt);
dput_and_out:
path_release(&nd);
out:
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Re: [PATCH 21/22] honor r/w changes at do_remo... Dave Hansen
- Re: [PATCH 21/22] honor r/w changes at do_remo... Anton Altaparmakov
- Re: [PATCH 21/22] honor r/w changes at do_remo... Jan Engelhardt
- [PATCH 05/22] elevate mnt writers for callers of vfs_mk... Dave Hansen
- [PATCH 09/22] mount_is_safe(): add comment Dave Hansen
- [PATCH 10/22] unix_find_other() elevate write count for... Dave Hansen
- [PATCH 11/22] elevate write count over calls to vfs_ren... Dave Hansen
- [PATCH 18/22] do_rmdir(): elevate write count Dave Hansen
- [PATCH 20/22] [PATCH] gfs: check nlink count Dave Hansen
- [PATCH 17/22] elevate mnt writers for vfs_unlink() call... Dave Hansen
- [PATCH 14/22] elevate write count for do_utimes() Dave Hansen
- [PATCH 16/22] sys_mknodat(): elevate write count for vf... Dave Hansen
- [PATCH 13/22] elevate writer count for do_sys_truncate(... Dave Hansen
- [PATCH 15/22] elevate write count for do_sys_utime() an... Dave Hansen
- [PATCH 12/22] elevate write count files are open()ed Dave Hansen
- Re: [PATCH 12/22] elevate write count files are op... Andrew Morton
- Re: [PATCH 12/22] elevate write count files ar... Dave Hansen
- Re: [PATCH 12/22] elevate write count file... Andrew Morton
- Re: [PATCH 12/22] elevate write count ... Dave Hansen
- [PATCH 19/22] elevate writer count for custom struct_fi... Dave Hansen
- [PATCH 22/22] kill open files traverse on remount ro Dave Hansen

