On Tuesday, July 26, 2016 9:41:50 PM CEST Dong Aisheng wrote:
>
> On Tue, Jul 26, 2016 at 8:32 PM, Arnd Bergmann <a...@arndb.de> wrote:
> > The driver has just gained a slightly incorrect pm-sleep implementation
> > that causes
> > warnings when CONFIG_PM is set but CONFIG_PM_SLEEP is not:
> >
> > drivers/mmc/host/sdhci-esdhc-imx.c:1302:12: error: 'sdhci_esdhc_resume'
> > defined but not used [-Werror=unused-function]
> > static int sdhci_esdhc_resume(struct device *dev)
> > ^~~~~~~~~~~~~~~~~~
> > drivers/mmc/host/sdhci-esdhc-imx.c:1297:12: error: 'sdhci_esdhc_suspend'
> > defined but not used [-Werror=unused-function]
> > static int sdhci_esdhc_suspend(struct device *dev)
> >
> > This replaces the incorrect #ifdef with a __maybe_unused annotation that
> > does
> > the right thing in all configurations and is more readable.
> >
> > Signed-off-by: Arnd Bergmann <a...@arndb.de>
> > Fixes: b70d0b3b5b29 ("mmc: sdhci-esdhc-imx: add esdhc specific suspend
> > resume callback")
>
> Thanks for the fix.
> Looks like the default kernel Makefile does not enable
> -Werror=unused-function wanrings,
> so did not expose it before.
They are enabled by default as warnings, not errors. My test build setup
uses -Werror to turn all warnings into errors so I can catch them
more easily as failed builds.
> Acked-by: Dong Aisheng <aisheng.d...@nxp.com>
>
Thanks,
Arnd
