On Fri, 2016-07-29 at 10:45 -0400, Allen Hubbe wrote: > On Wed, Jul 27, 2016 at 8:41 PM, Joe Perches <[email protected]> wrote: > > > > I think this is not a great idea because the most likely > > use case is piping git diff output ala: > > > > $ git diff <some_path> | ./scripts/checkpatch.pl - > Thanks for the review. Has v2 addressed your concern?
Hi Allen. For the most part, yes, your V2 works better. I was wondering if the - should be optional and thinking $ git diff <some-path> | ./scripts/checkpatch.pl should work the same way, but I guess that can wait for another day, so Acked-by: Joe Perches <[email protected]> cheers, Joe
